Added files for Pull request template#31
Conversation
|
hi @sapatevaibhav @thedevyashsaini , by mistake i had linked the #28 also to this pull request , please consider this two also . |
|
Why are there changes in 7 files? |
As i had added the code for #28 in the same PR by Mistake |
|
if every thing looks good we can move forward @thedevyashsaini |
Hi @sapatevaibhav , i had added the template which ask to describe the PR , like which issue does it close , why are we need this changes , what changes included . are this changes tested ? any other notes . |
|
|
|
Hi @sapatevaibhav , i think its ready . please have a look |
itspsychocoder
left a comment
There was a problem hiding this comment.
As mentioned, you have also merged #28, but your useFastSudo.ts hook file is empty and also you are importing sudo.rs in main file and using functions which are not implemented as your sudo.rs is empty.
|
@itspsychocoder i had pushed some changes take a look |
Closes #27 . please take a look around @thedevyashsaini @sapatevaibhav