Skip to content

Conversation

@IDavGal
Copy link
Collaborator

@IDavGal IDavGal commented Jan 29, 2025

Added OS-required files.
If you can, PTAL to the documentation files @agalbachicar

Signed-off-by: IDavGal <ignacio.davila@creativa77.com.ar>
Signed-off-by: IDavGal <ignacio.davila@creativa77.com.ar>
Signed-off-by: IDavGal <ignacio.davila@creativa77.com.ar>
@IDavGal IDavGal requested a review from WagnerMarcos January 29, 2025 12:49
@IDavGal IDavGal self-assigned this Jan 29, 2025
Signed-off-by: IDavGal <ignacio.davila@creativa77.com.ar>
Copy link
Member

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, I could not test it yet. PTAL.

CONTRIBUTING.md Outdated
@@ -0,0 +1,35 @@
## Contributing to flatland_demo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE.md Outdated
@@ -0,0 +1,29 @@
BSD 3-Clause License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please replace it by Apache 2.0.

Signed-off-by: IDavGal <ignacio.davila@creativa77.com.ar>
Signed-off-by: IDavGal <ignacio.davila@creativa77.com.ar>
Signed-off-by: IDavGal <ignacio.davila@creativa77.com.ar>
@IDavGal
Copy link
Collaborator Author

IDavGal commented Jan 29, 2025

@agalbachicar @WagnerMarcos Addresed comments and uploaded a series of test rosbags. To replay them run the play_n_rosbags launchfile with nr:=12, which is the amount of robots by default in the multi_robot script.

Copy link
Member

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IDavGal IDavGal merged commit 3143ebf into main Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants