fix(client): 允许没有打任何特性的接口被设置成服务端和客户端

ElderJames · Jan 18, 2018 · 58eaa7a · 58eaa7a
1 parent 94e7d58
commit 58eaa7a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/....WebApiProxy/Contracts/ITcpTestService.cs → ...WebApiProxy/Contracts/ISimpleInterface.cs b/....WebApiProxy/Contracts/ITcpTestService.cs → ...WebApiProxy/Contracts/ISimpleInterface.cs
@@ -2,7 +2,7 @@
 
 namespace Shriek.Samples.WebApiProxy.Contracts
 {
-    public interface ITcpTestService
+    public interface ISimpleInterface
     {
         Task<string> Test(string sth);
     }

diff --git a/samples/Shriek.Samples.WebApiProxy/Program.cs b/samples/Shriek.Samples.WebApiProxy/Program.cs
@@ -25,6 +25,7 @@ public static void Main(string[] args)
                             {
                                 opt.AddWebApiProxy<SampleApiProxy>();
                                 opt.AddWebApiProxy<Samples.Services.SampleApiProxy>();
+                                opt.AddService<ISimpleInterface>();
                             });
 
                     //服务里注册代理客户端
@@ -42,13 +43,14 @@ public static void Main(string[] args)
                 {
                     opt.AddWebApiProxy<SampleApiProxy>("http://localhost:8081");
                     opt.AddWebApiProxy<Samples.Services.SampleApiProxy>("http://localhost:8080");
+                    opt.AddService<ISimpleInterface>("http://localhost:8080");
                 })
                 .BuildServiceProvider();
 
             var todoService = provider.GetService<ITodoService>();
             var testService = provider.GetService<ITestService>();
             var sampleTestService = provider.GetService<Samples.Services.ITestService>();
-            var tcpService = provider.GetService<ITcpTestService>();
+            var tcpService = provider.GetService<ISimpleInterface>();
 
             Console.ReadKey();
 
@@ -71,11 +73,8 @@ public static void Main(string[] args)
             var result3 = sampleTestService.Test("elderjames").Result;
             Console.WriteLine(JsonConvert.SerializeObject(result3));
 
-            Console.WriteLine("press any key to tcp testing...");
-            Console.ReadKey();
-
-            //var result4 = tcpService.Test("hahaha").Result;
-            //Console.WriteLine(JsonConvert.SerializeObject(result4));
+            var result4 = tcpService.Test("hahaha").Result;
+            Console.WriteLine(JsonConvert.SerializeObject(result4));
 
             Console.ReadKey();
         }

diff --git a/...es.WebApiProxy/Services/TcpTestService.cs → ....WebApiProxy/Services/ISimpleInterface.cs b/...es.WebApiProxy/Services/TcpTestService.cs → ....WebApiProxy/Services/ISimpleInterface.cs
@@ -3,7 +3,7 @@
 
 namespace Shriek.Samples.WebApiProxy.Services
 {
-    public class TcpTestService : ITcpTestService
+    public class SimpleInterface : ISimpleInterface
     {
         public async Task<string> Test(string sth)
         {

diff --git a/src/Shriek.ServiceProxy.Http/WebApiProxyExtensions.cs b/src/Shriek.ServiceProxy.Http/WebApiProxyExtensions.cs
@@ -45,8 +45,7 @@ public static IServiceCollection AddWebApiProxy(this IServiceCollection service,
 
             foreach (var type in option.RegisteredServices)
             {
-                if (type.Value.IsInterface && type.Value.GetMethods()
-                        .SelectMany(m => m.GetCustomAttributes(typeof(ApiActionAttribute), true)).Any())
+                if (type.Value.IsInterface/* && type.Value.GetMethods().SelectMany(m => m.GetCustomAttributes(typeof(ApiActionAttribute), true)).Any()*/)
                 {
                     var proxy = ProxyGenerator.CreateInterfaceProxyWithoutTarget(type.Value, new HttpApiClient(type.Key ?? option.ProxyHost));
                     service.AddSingleton(type.Value, x => proxy);