Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDs in Base64 Image Placeholders #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Dec 9, 2021

  1. Added Base64 Image ID to help with Lighthouse.

    Lighthouse sometimes dislikes ElderJS's base64 placeholder pictures.
    Usually, it lets you know that the placeholder needs to be resized.
    Unfortunately, Lighthouse doesn't help you identify the image well.
    Which means on pages with lots of pictures, this is a pain.
    Having an ID embedded in the data URL fixes this.
    It does make pages slightly larger, but I feel the tradeoff is worth it.
    Michael Pope committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    f5060ca View commit details
    Browse the repository at this point in the history
  2. Formatted the git pull request more nicely.

    Michael Pope committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    798474a View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Made a small extra note about truncated ids.

    Michael Pope committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    3f3eb23 View commit details
    Browse the repository at this point in the history