return models when reordering

ElegantEngineeringTech · Jan 11, 2024 · 076beb2 · 076beb2
1 parent 1067381
commit 076beb2
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/Models/Media.php b/src/Models/Media.php
@@ -468,17 +468,18 @@ public function getSrcset(?string $conversion = null): Collection
 
     /**
      * @param  null|(Closure(null|string $previous): string)  $sequence
+     * @return EloquentCollection<int, static>
      */
-    public static function reorder(array $keys, ?Closure $sequence = null, string $using = 'id'): void
+    public static function reorder(array $keys, ?Closure $sequence = null, string $using = 'id'): EloquentCollection
     {
-        /** @var EloquentCollection<int, Media> */
+        /** @var EloquentCollection<int, static> */
         $models = static::query()
             ->whereIn($using, $keys)
             ->get();
 
         $models = $models->sortBy(function (Media $model) use ($keys, $using) {
             return array_search($model->{$using}, $keys);
-        });
+        })->values();
 
         $previous = $sequence ? null : -1;
 
@@ -491,5 +492,7 @@ public static function reorder(array $keys, ?Closure $sequence = null, string $u
             $model->save();
         }
 
+        return $models;
+
     }
 }