-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERL-467: nemos-images-reference-*: *: add checkbox-erlangen-classic snap #55
Conversation
Requires #54 |
cb4da73
to
1ea8512
Compare
Add the custom Checkbox snap created for the project. This contains all of the project-specific test suites that we require. Signed-off-by: Isaac True <isaac.true@canonical.com>
1ea8512
to
c7c915b
Compare
Signed-off-by: Isaac True <isaac.true@canonical.com>
a05e2f8
to
5b40ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on development profile for mantic reference image.
# snap list checkbox-erlangen-classic
Name Version Rev Tracking Publisher Notes
checkbox-erlangen-classic 0.1dev 2 latest/stable ce-certification-qa classic
Thank you Isaac for adding spread tests.
ba9e839
to
53dfaee
Compare
If building a "reference" image, we want to use the development profile in order to include all snaps. Signed-off-by: Isaac True <isaac.true@canonical.com>
… installed Signed-off-by: Isaac True <isaac.true@canonical.com>
Signed-off-by: Isaac True <isaac.true@canonical.com>
53dfaee
to
211d75b
Compare
CI fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes required, please see my inline comments
Signed-off-by: Alexandre Esse <alexandre.esse@canonical.com>
…pendency `checkbox` snap has launchers built-in but the one we use are in `checkbox-erlangen-classic` which has launchers and providers (in checkbox term, the jobs and testplans), but doesn't have checkbox-runtime so we still depend on `checkbox22` to provide the service and also the generic providers. Signed-off-by: Alexandre Esse <alexandre.esse@canonical.com>
93053e6
to
a73372a
Compare
LGTM, thanks for the additions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you
Add the custom Checkbox snap created for the project. This contains all of the project-specific test suites that we require.