allow style support for Jupyter on Windows

ElementalCognition · Feb 25, 2021 · 43d1bcf · 43d1bcf
1 parent 80086c4
commit 43d1bcf
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -170,6 +170,7 @@ Unreleased
     ``default=None``. :issue:`1381`
 -   Option prompts validate the value with the option's callback in
     addition to its type. :issue:`457`
+-   Allow styled output in Jupyter on Windows. :issue:`1271`
 
 
 Version 7.1.2

diff --git a/setup.cfg b/setup.cfg
@@ -95,5 +95,8 @@ warn_unreachable = True
 [mypy-click]
 no_implicit_reexport = False
 
+[mypy-colorama.*]
+ignore_missing_imports = True
+
 [mypy-importlib_metadata.*]
 ignore_missing_imports = True
diff --git a/src/click/_compat.py b/src/click/_compat.py
@@ -471,11 +471,6 @@ def strip_ansi(value):
 
 
 def _is_jupyter_kernel_output(stream):
-    if WIN:
-        # TODO: Couldn't test on Windows, should't try to support until
-        # someone tests the details wrt colorama.
-        return
-
     while isinstance(stream, (_FixupStream, _NonClosingTextIOWrapper)):
         stream = stream._stream
 
@@ -521,7 +516,7 @@ def auto_wrap_for_ansi(
 
         strip = should_strip_ansi(stream, color)
         ansi_wrapper = colorama.AnsiToWin32(stream, strip=strip)
-        rv = ansi_wrapper.stream
+        rv = t.cast(t.TextIO, ansi_wrapper.stream)
         _write = rv.write
 
         def _safe_write(s):

diff --git a/tests/test_compat.py b/tests/test_compat.py
@@ -1,10 +1,6 @@
-import pytest
-
 from click._compat import should_strip_ansi
-from click._compat import WIN
 
 
-@pytest.mark.xfail(WIN, reason="Jupyter not tested/supported on Windows")
 def test_is_jupyter_kernel_output():
     class JupyterKernelFakeStream:
         pass