Skip to content

Commit

Permalink
Merge #7: Elip100 fixes
Browse files Browse the repository at this point in the history
6abc856 elip-0100: Increase lenght of invalid ticker (Riccardo Casatta)
86370e3 elip-0100: fix asset metadata value test vector (Riccardo Casatta)

Pull request description:

  Proposed fixes found while doing PR for rust-elements ElementsProject/rust-elements#182

  In particular about the proposed change for the value, there is a test showing the changed bytes are only the ones involving the txid: https://github.com/ElementsProject/rust-elements/pull/182/files#diff-cde6cc19a998ab9ddf07c6afe978e4129b8d196bc347bcfe79caf2134fabd2a7R371

Top commit has no ACKs.

Tree-SHA512: 6d710cd7b808092d92cac9210fd238c8e92e0e3a42d485d3c2a7bc32b844cf0b67b869f48dc0480ec1403c3e250c308b0f958fe8acf65827365d52b307ff3188
  • Loading branch information
apoelstra committed Nov 13, 2023
2 parents b8bef62 + 6abc856 commit 8f8d45d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions elip-0100.mediawiki
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ Valid asset metadata record in PSET composed of the listed below values:
Resulting asset metadata record:
key : fc08707365745f6877770018befcc6cd9cece63ab0dc323e99fe4aaa59864a0dc913c3fde8342f6235f848
value : b47b22656e74697479223a7b22646f6d61696e223a226578616d706c652e636f6d227d2c226973737565725f7075626b6579223a22303334353565653763656463393762306261343335623830303636666339326339363361333463363030333137393831643133353333306334656534336163376133222c226e616d65223a2254657374636f696e222c22707265636973696f6e223a322c227469636b6572223a2254455354222c2276657273696f6e223a307d3514a07cf4812272c24a898c482f587a51126beef8c9b76a9e30bf41b0cbe53c01000000
value : b47b22656e74697479223a7b22646f6d61696e223a226578616d706c652e636f6d227d2c226973737565725f7075626b6579223a22303334353565653763656463393762306261343335623830303636666339326339363361333463363030333137393831643133353333306334656534336163376133222c226e616d65223a2254657374636f696e222c22707265636973696f6e223a322c227469636b6572223a2254455354222c2276657273696f6e223a307d3ce5cbb041bf309e6ab7c9f8ee6b12517a582f488c894ac2722281f47ca0143501000000

Invalid contracts that should be detected by contract parser:

* Missing ticker: <pre>{"entity":{"domain":"example.com"},"issuer_pubkey":"03455ee7cedc97b0ba435b80066fc92c963a34c600317981d135330c4ee43ac7a3","name":"Testcoin","precision":2,"version":0}</pre>
* Missing precision: <pre>{"entity":{"domain":"example.com"},"issuer_pubkey":"03455ee7cedc97b0ba435b80066fc92c963a34c600317981d135330c4ee43ac7a3","name":"Testcoin","ticker":"TEST","version":0}</pre>
* Ticker is too long: <pre>{"entity":{"domain":"example.com"},"issuer_pubkey":"03455ee7cedc97b0ba435b80066fc92c963a34c600317981d135330c4ee43ac7a3","name":"Testcoin","precision":2,"ticker":"TEST1234567","version":0}</pre>
* Ticker is too long: <pre>{"entity":{"domain":"example.com"},"issuer_pubkey":"03455ee7cedc97b0ba435b80066fc92c963a34c600317981d135330c4ee43ac7a3","name":"Testcoin","precision":2,"ticker":"1234567890123456789012345","version":0}</pre>
* Forbidden whitespace:<pre>{"entity":{"domain":"example.com"}, "issuer_pubkey":"03455ee7cedc97b0ba435b80066fc92c963a34c600317981d135330c4ee43ac7a3","name":"Testcoin","precision":2,"ticker":"TEST","version":0}</pre>
* Duplicate key (name):<pre>{"entity":{"domain":"example.com"},"issuer_pubkey":"03455ee7cedc97b0ba435b80066fc92c963a34c600317981d135330c4ee43ac7a3","name":"Testcoin","name":"Othercoin","precision":2,"ticker":"TEST","version":0}</pre>
* Non-sorted keys:<pre>{"name":"Testcoin","entity":{"domain":"example.com"},"issuer_pubkey":"03455ee7cedc97b0ba435b80066fc92c963a34c600317981d135330c4ee43ac7a3","precision":2,"ticker":"TEST","version":0}</pre>
Expand Down

0 comments on commit 8f8d45d

Please sign in to comment.