Fix WASM build and add a job in CI #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note downstream you can use this without the dev-dep obviously, this is just needed to enforce wasm check in CI so that we are not breaking it in the future |
apoelstra
reviewed
Aug 22, 2024
| - name: Checkout Toolchain | ||
| uses: dtolnay/rust-toolchain@stable | ||
| - run: rustup target add wasm32-unknown-unknown | ||
| - run: cargo check --target wasm32-unknown-unknown |
There was a problem hiding this comment.
In d6c5892:
trailing whitespace
|
LGTM, but would this check have actually caught the getrandom thing? My understanding is that if you compile without the Regardless, this CI job is an improvement over having nothing. |
|
It seems it's a compile time check and without the getrandom thing the job would fail https://github.com/RCasatta/rust-elements/actions/runs/10578325188/job/29308193852?pr=2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #194