-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Bulk Digestion in Gastric Acid #150
Feat: Bulk Digestion in Gastric Acid #150
Conversation
src/main/java/com/github/elenterius/biomancy/mixin/ItemEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/mixin/ItemEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/mixin/ItemEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
(Implement requested changes)
Implemented the changes I resolved. As for the others-
|
…s' into mc1.20.1/feat/acid-digests-things
I'm planning to phase out the use of vanilla inventory containers and my extensions of it (BehavioralInventory) in favor of simply using (neo-)forges ItemStackHandler interfaces. The recipe wrapper is just used when you need a vanilla inventory container for assembling recipes, etc. Example: RecipeWrapper inv = new RecipeWrapper(new ItemStackHandler(1));
inv.setItem(0, inputStack);
ItemStack resultStack = recipe.assemble(inv, level.registryAccess()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to format your file ;)
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/elenterius/biomancy/init/AcidInteractions.java
Outdated
Show resolved
Hide resolved
no idea whats going on with that but if you feel like it you can include the removed code for the particle in the PR (or link to a branch with the code) and i will look into it at a later point. I'm mentioning this because i do want to spruce up acid fluid with bubbles. |
Will do, I've been busy with IRL stuff the last week, hence why I haven't touched it lol Edit: I got them working in the latest batch of commits. Probably related to #151 - particles don't render through Acid without Fabulous graphics, which pretty thoroughly ruins the effect :( |
…o mc1.20.1/feat/acid-digests-things # Conflicts: # src/main/resources/mixins.biomancy.json
Implement requested changes Note: Particles (even Vanilla ones) don't render under/through Acid without Fabulous graphics enabled. Likely related to [Elenterius#151](Elenterius#151)
Implement requested changes Note: Particles (even Vanilla ones) don't render under/through Acid without Fabulous graphics enabled. Likely related to [Elenterius#151](Elenterius#151)
Implement requested changes Note: Particles (even Vanilla ones) don't render under/through Acid without Fabulous graphics enabled. Likely related to [Elenterius#151](Elenterius#151)
…s' into mc1.20.1/feat/acid-digests-things
We love redundant merging! (6f01210) |
Throw digestible item in acid, get nutrient paste out.
Has a 80% efficiency when compared the the digester for balance, but the fact that you have to grow your cradle enough to get acid is also a component.
Fairly simple to change the efficiency on it, it's in AcidInteractions.
Annoyingly, neither Forge nor Minecraft give a clean way to get JUST item entities during a tick, so I had to Mixin into ItemEntity.tick()