Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Bulk Digestion in Gastric Acid #150

Merged

Conversation

kd8lvt
Copy link
Contributor

@kd8lvt kd8lvt commented Oct 2, 2024

Throw digestible item in acid, get nutrient paste out.
Has a 80% efficiency when compared the the digester for balance, but the fact that you have to grow your cradle enough to get acid is also a component.

Fairly simple to change the efficiency on it, it's in AcidInteractions.

Annoyingly, neither Forge nor Minecraft give a clean way to get JUST item entities during a tick, so I had to Mixin into ItemEntity.tick()

@Elenterius Elenterius self-requested a review October 2, 2024 22:17
@kd8lvt
Copy link
Contributor Author

kd8lvt commented Oct 4, 2024

Implemented the changes I resolved. As for the others-

  • Particles: I wanted to do them for the visual feedback of something happening, but even after creating an entirely different particle that's just a green bubble that doesn't care where it is, (and switching to clientside of course,) still no bueno.
  • RecipeWrapper: Still unsure what you mean by this; I'm more than willing to learn, just haven't quite figured out how you'd want me to use/implement that specifically.

@kd8lvt kd8lvt requested a review from Elenterius October 4, 2024 17:52
@Elenterius
Copy link
Owner

Elenterius commented Oct 4, 2024

RecipeWrapper: Still unsure what you mean by this; I'm more than willing to learn, just haven't quite figured out how you'd want me to use/implement that specifically.

I'm planning to phase out the use of vanilla inventory containers and my extensions of it (BehavioralInventory) in favor of simply using (neo-)forges ItemStackHandler interfaces. The recipe wrapper is just used when you need a vanilla inventory container for assembling recipes, etc.

Example:

RecipeWrapper inv = new RecipeWrapper(new ItemStackHandler(1));
inv.setItem(0, inputStack);
ItemStack resultStack = recipe.assemble(inv, level.registryAccess());

Copy link
Owner

@Elenterius Elenterius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to format your file ;)

@Elenterius
Copy link
Owner

Elenterius commented Oct 4, 2024

Particles: I wanted to do them for the visual feedback of something happening, but even after creating an entirely different particle that's just a green bubble that doesn't care where it is, (and switching to clientside of course,) still no bueno.

no idea whats going on with that but if you feel like it you can include the removed code for the particle in the PR (or link to a branch with the code) and i will look into it at a later point. I'm mentioning this because i do want to spruce up acid fluid with bubbles.

@kd8lvt
Copy link
Contributor Author

kd8lvt commented Oct 9, 2024

Particles: I wanted to do them for the visual feedback of something happening, but even after creating an entirely different particle that's just a green bubble that doesn't care where it is, (and switching to clientside of course,) still no bueno.

no idea whats going on with that but if you feel like it you can include the removed code for the particle in the PR (or link to a branch with the code) and i will look into it at a later point. I'm mentioning this because i do want to spruce up acid fluid with bubbles.

Will do, I've been busy with IRL stuff the last week, hence why I haven't touched it lol

Edit: I got them working in the latest batch of commits. Probably related to #151 - particles don't render through Acid without Fabulous graphics, which pretty thoroughly ruins the effect :(

kd8lvt added 4 commits October 9, 2024 16:43
…o mc1.20.1/feat/acid-digests-things

# Conflicts:
#	src/main/resources/mixins.biomancy.json
Implement requested changes
Note: Particles (even Vanilla ones) don't render under/through Acid without Fabulous graphics enabled. Likely related to [Elenterius#151](Elenterius#151)
Implement requested changes
Note: Particles (even Vanilla ones) don't render under/through Acid without Fabulous graphics enabled. Likely related to [Elenterius#151](Elenterius#151)
Implement requested changes
Note: Particles (even Vanilla ones) don't render under/through Acid without Fabulous graphics enabled. Likely related to [Elenterius#151](Elenterius#151)
@kd8lvt kd8lvt requested a review from Elenterius October 10, 2024 03:10
@kd8lvt
Copy link
Contributor Author

kd8lvt commented Oct 10, 2024

We love redundant merging! (6f01210)
Woops.

@Elenterius Elenterius merged commit aba3a91 into Elenterius:mc1.20.1/dev Oct 11, 2024
1 check failed
@kd8lvt kd8lvt deleted the mc1.20.1/feat/acid-digests-things branch October 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants