cohort 17 changes

.vscode/launch.json

@@ -11,7 +11,7 @@
       "skipFiles": [
         "<node_internals>/**"
       ],
-      "program": "${file}"
+      "program": "${workSpaceFolder}/server.js"
     }
   ]
 }

dist/index.html

@@ -24,7 +24,10 @@
             <p class="name">{{firstName}} {{lastName}}</p>
             <p class="number">{{jersey}}</p>
             <div class="player-image">
-                <img src="https://nba-players.herokuapp.com/players/{{lastName}}/{{firstName}}" onerror="setDefaultImg(this)">
+                <img
+                    src="{{img}}"
+                    onerror="setDefaultImg(this)"
+                >
             </div>
             <p class="pos">{{pos}}</p>
         </div>

dist/main.js

@@ -8,7 +8,7 @@ const render = function (roster) {
 
 const fetch = function () {
     const input = $(`#input`).val().toLowerCase()
-    $.get(`/teams/${input}`, function (response) {
+    $.get(`/api/teams/${input}`, function (response) {
         render(response)
     })
 }

server.js

@@ -3,6 +3,7 @@ const express = require('express')
 const path = require('path')
 const bodyParser = require('body-parser')
 const api = require('./server/routes/api')
+
 const app = express()
 
 
@@ -11,11 +12,9 @@ app.use(express.static(path.join(__dirname, 'node_modules')))
 app.use(bodyParser.json())
 app.use(bodyParser.urlencoded({ extended: false }))
 
-app.use('/', api)
+app.use('/api', api)
 
 const port = 3000
 app.listen(port, function () {
     console.log(`Running server on port ${port}`)
-})
-
-
+})

server/routes/api.js

@@ -21,13 +21,31 @@ urllib.request('http://data.nba.net/10s/prod/v1/2018/players.json', (err, res) =
 })
 
 router.get(`/teams/:teamName`, (req, res) => {
-    const teamID = teamToIDs[req.params.teamName]
+    // const teamName = req.params.teamName
+    const { teamName } = req.params
+    const [a, b] = ['shobbi', 'doobi']
+
+    if (teamToIDs[teamName]) {
+
+        const teamID = teamToIDs[teamName]
+
+        const team = json.data
+            .filter(p => p.teamId === teamID && p.isActive)
+            .map(p => {
+                return {
+                    firstName: p.firstName,
+                    lastName: p.lastName,
+                    jersey: p.jersey || 'unavailable',
+                    pos: p.pos,
+                    img:`https:nba-players.herokuapp.com/players/${p.lastName}/${p.firstName}`
+                }
+            })
+
+        res.send(team)
+    } else {
+        res.send({ error: 'not found' })
+    }
 
-    const team = json.data
-        .filter(p => p.teamId === teamID && p.isActive)
-        .map(p => { return { firstName: p.firstName, lastName: p.lastName, jersey: p.jersey, pos: p.pos } })
-
-    res.send(team)
 })
 
 module.exports = router