State switching rework with other bugfixes #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserving them will cause issues with server switching
UserNugget
force-pushed
the
fixing-issues
branch
from
6bc395a to
9401389
Compare
UserNugget
changed the title
mdxd44
pushed a commit
that referenced
this pull request
May 4, 2024
* Properly check for pending disconnection * Force synchronize rejoin state switching * Deduplicate prepared config packets * Don't preserve ConfirmHandler and ClientPlaySessionHandler Preserving them will cause issues with server switching * Close "confirming" connection on spam * Speedup 1.20.3+ world loading by following Vanilla behavior * Synchronize LOGIN transition * Ensure that FastPrepareAPI encoder matches current state * Remove NbtUtils as Velocity now supports 1.20.2 NBT * Check for a custom PLAY state while sending UpsertPlayerInfo * Rollback CONFIG handler on server switch * Move the entire PLAY->CONFIG transition logic to the LimboSessionHandlerImpl * Fix invalid CONFIG packets being sent at PLAY state * Mitigate clientside race condition * Small improvements * Fix race condition mitigation then rejoin is disabled * Fix LoginEvent sending a LOGIN disconnect instead of CONFIG/PLAY one Former-commit-id: 78231bd
mdxd44
pushed a commit
that referenced
this pull request
May 4, 2024
* Properly check for pending disconnection * Force synchronize rejoin state switching * Deduplicate prepared config packets * Don't preserve ConfirmHandler and ClientPlaySessionHandler Preserving them will cause issues with server switching * Close "confirming" connection on spam * Speedup 1.20.3+ world loading by following Vanilla behavior * Synchronize LOGIN transition * Ensure that FastPrepareAPI encoder matches current state * Remove NbtUtils as Velocity now supports 1.20.2 NBT * Check for a custom PLAY state while sending UpsertPlayerInfo * Rollback CONFIG handler on server switch * Move the entire PLAY->CONFIG transition logic to the LimboSessionHandlerImpl * Fix invalid CONFIG packets being sent at PLAY state * Mitigate clientside race condition * Small improvements * Fix race condition mitigation then rejoin is disabled * Fix LoginEvent sending a LOGIN disconnect instead of CONFIG/PLAY one Former-commit-id: 78231bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically fix several issues with state switching and has some other improvements
Fixes Elytrium/LimboAuth#134
Require Elytrium/FastPrepareAPI#2 to compile