Fix pffft benchmark bug and add config validation tests#58
Merged
Conversation
- Fix PFFFT_REAL enum: was incorrectly 1, should be 0 (rfft.bench.js) - Add shared competitor config (benchmarks/lib/competitors.js) - Add benchmark-correctness test to catch config drift - Update third-party tests to use shared config - Update CI to run test:all instead of just npm test - Refresh README benchmark numbers with corrected pffft results
EmNudge
force-pushed
the
fix-pffft-benchmark-validation
branch
from
24f9efb to
aeab9f8
Compare
Playground PreviewDeployed to Cloudflare Pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmarks/lib/competitors.js) as single source of truthbenchmark-correctness.test.jsto catch config drift between benchmarks and teststest:allinstead of justnpm testDetails
The pffft real FFT benchmark was using
PFFFT_REAL = 1but the correct value is0(from pffft.h:enum { PFFFT_REAL=0, PFFFT_COMPLEX=1 }). This caused pffft to run complex FFT on real data, making it appear slower than it actually is.With the fix, pffft now correctly beats wat-fft at N=64 for real FFT.