refactor: consolidate module checks, optimize lookups, fix clippy lints#261
Merged
refactor: consolidate module checks, optimize lookups, fix clippy lints#261
Conversation
EmNudge
force-pushed
the
refactor-consolidate-module-checks
branch
from
8fc0cab to
e897f83
Compare
|
| Category | Base | PR | Delta |
|---|---|---|---|
| Total pass | 6040 | 6040 | — |
| Total fail | 6 | 6 | — |
| Total skip | 58577 | 58577 | — |
| Valid modules | 2127/2128 | 2127/2128 | — |
| assert_invalid | 2684/2689 | 2684/2689 | — |
| assert_malformed | 1229/1229 | 1229/1229 | — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONST_INSTRUCTIONSlinear scan withmatches!()for O(1) const expression validationvalidate_const_instr()helper to de-duplicate instr_plain/expr1_plain validationentryAPI instead ofcontains_key+insert(3 call sites)IdentifierMapsstruct, removingtoo_many_argumentslintBLOCK_KINDS_*array lookups withmatches!()and remove unused constantsfind_param_in_function/find_local_in_function/find_block_in_functionhelpers in references_core