Merge develop to aiim #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waf 2.0.18 uses the Python module 'imp', which is removed in Python 3.12 and later. This issue has been addressed in Waf v2.0.19 and later versions. Update Waf to the latest release v2.1.1. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Ubuntu 24.04, the latest LTS release, is currently in beta for GitHub Actions, but it seems to work well for libcsp. This commit adds support for Ubuntu 24.04 as a new platform. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
can_socketcan.c doesn't work without libsocketcan installed. Compile can_socketcan.c only when libsocketcan-dev is detected. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
RTABLE is disabled by default, but the Python bindings unconditionally call these functions. Added ifdef statements around RTABLE functions. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
…r overflow Fix unchecked `outlen `parameter in `csp_transaction_persistent`. Remove size from csp_buffer_get() Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Fix unchecked `size` parameter in `csp_ping`. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
The commit 55d4437 fixed a bug where the file global variable tx_queue was accessed instead of the provided queue. This went unnoticed because accessing tx_queue was valid, though incorrect. To prevent this issue in the future, we are moving __csp_rdp_queue_flush() before the file global variable declarations. With this change, the compiler can at least issue a warning. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
The methods `csp_rdp_queue_tx_add` and `csp_rdp_queue_rx_add` currently share the same functionality. This commit consolidates them into a single function. Similarly, `csp_rdp_queue_tx_get` and `csp_rdp_queue_rx_get` have been merged into one function to eliminate duplication.
The return values of csp_route_security_check() and csp_conn_enqueue_packet() are compared directly to 0. This commit updates the comparison to use CSP_ERR_NONE, which both functions return to indicate success.
Add gitlint for checking git commit messages. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Add GitHub issue templates for Q&A and Bug Report. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Add build and test python binding. This commit aim to help to found if there are any build error in python binding. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Update return value to use CSP_ERR_NONE instead of 0 to indicate success. No functionality has been changed. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
The csp_bind_callback() function returns debug error codes. This commit updates the return values to use the official error codes from csp_error.h.
The actions/setup-python action allows us to set up and use various Python versions. With this change, we can test our binding against multiple versions instead of the already installed one. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
The "name" field is displayed in GitHub's checks area. Having a distinguishable name at the leftmost position makes it easier to read. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
C99 introduced the predefined magic constant __func__. Replaced the older __FUNCTION__ with __func__ for consistency. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
C99 introduced the predefined magic constant __func__. Replaced the older __FUNCTION__ with __func__ for consistency. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
C99 introduced the predefined magic constant __func__. Replaced the older __FUNCTION__ with __func__ for consistency. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
The %p format specifier in printf()/fprintf() expects a void* argument.
The C standard (N2310, section 7.21.6.1) states that:
If any argument is not the correct type for the corresponding
conversion specification, the behavior is undefined.
Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Both csp_queue_empty() and pthread_queue_empty() doesn't return anything. "ISO C forbids ‘return’ with expression, in function returning void." The warning is visible if you build with -pedantic Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Meson 1.2 and earlier don't support Python 3.12 due to the removal of distutils. To support Python 3.12, Meson 1.3 or later is required. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
We currently only support "posix" in this workflow, so there's no need to include it in the arch matrix. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
We currently only support "posix" in this workflow, so there's no need to include it in the arch matrix. Additionally, macos-latest is not supported by the current libcsp. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
We previously supported multiple target OSes, but now we only support Linux or "posix". The other OSes were removed in commit 7efd343. As a result, the 'rest' argument is no longer used, so we're removing it. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Compiling for most targets, left bit shifts of "small" data types might cause integer promotion. On a 32 bit system, for example, left-shifting the priority promotes it to a signed 32 bit integer. The priority is a 2 bit value that is left-shifted to bit position 30, thereby overwriting the sign bit. This causes some analyzers (e.g. GCC sanitizer) to issue an error. The clean solution is to cast the variables to the proper lvalue data type of the assignment *before* left-shifting.
Refactored csp_rdp_queue_get by moving the else block outside of the if condition. The csp_rdp_queue_add call is now at the end of the loop, clearly indicating that the packet is re-added to the queue when it doesn't match the connection. No functionality has been changed. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
On the CSP Queue section of the libcsp documentation page, the function csp_queue_create_static does not appear. I have added functions comments to solve this issue. Signed-off-by: alexapostolu <apostolu240@gmail.com>
Use ubuntu-latest if we don't have any special reason. With it, we don't have to update every time the VM image for GitHub Actions is updated. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
We don't use multiple OSes to run the ABI checker. Remove matrix.os. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Fix EOF newlines Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Remove executive newlines at EOF. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
The C standard requires that "A source file that is not empty shall end with a newline character, which shall not be immediately preceded by a backslash character before any such splicing takes place." This workflow ensures compliance with this requirement. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
This commit introduces a contributing guide to help developers understand the process for contributing to libcsp, including coding standards, commit message guidelines, and the pull request review process. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.