Merged
Conversation
When adding crates to the visit stack based upon a dependent's enabled features, we were pruning crates due to a (IMO bug) oddity of cargo metadata, where the resolved nodes refer to the lib target name rather than the package name, unless the dependent renames it themselves. For 99.99% of crates this doesn't matter, but eg. rust-ini renames its lib target to 'ini' which would cause the entire rust-ini crate to be pruned if it was not renamed AND feature gated, eg. config -> ini -> rust-ini
bytes has a vulnerability, and tame-index nuked reqwest which removes a fuckton of dependencies
Jake-Shadle
force-pushed
the
fix-lib-rename
branch
from
dc98887 to
50924bc
Compare
Jake-Shadle
added a commit
to EmbarkStudios/cargo-deny
that referenced
this pull request
Apr 1, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding crates to the visit stack based upon a dependent's enabled features, we were pruning crates due to a (IMO bug) oddity of cargo metadata, where the resolved nodes refer to the lib target name rather than the package name, unless the dependent renames it themselves. For 99.99% of crates this doesn't matter as maintainers don't rename their lib targets, but eg.
rust-inirenames its lib target toiniwhich would cause the entirerust-inicrate to be pruned if it was not renamed AND feature gated, eg.config->ini->dep:rust-ini->rust-iniResolves: #106