-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add road points reducing algorithm #14
Conversation
Hi Aarav, Thanks for doing this, really excited to try this out! I have three questions:
|
So I have tested it by running rendering. You can run it from here - https://github.com/facebookresearch/nocturne/blob/main/examples/rendering.py
Yes. You can set the reducing_threshold in the config to 0. Note the condition in the code to skip a point is using strictly less than (<) operator. Since area can never be < 0, it will include all the points.
I can take a look at how the observations are formed. |
Yeah, this won't change the observation size. We'd need to change the values of num_road_points in the observation config for that. We can pick a good value for that by looking at the renderings of the agent view once we pick a threshold |
@aaravpandya thanks for your answers and please let me know if your second sanity check succeeds. I'll also try it out on the RL end this week. As for decreasing the observation size, it would be nice to have it in Nocturne, but I'd say it is probably not worth spending more than 3 hours on it given that we're migrating to gpudrive within a couple of weeks. Unless you can re-use the code for gpudrive as well, of course. |
This PR aims to do the following:
This is not final PR. Some changes maybe made as per preferences -