-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul how iOS build distribution installation works #49
Conversation
require 'cfpropertylist' | ||
|
||
module EmergeCLI | ||
class XcodeDeviceManager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth on the naming here and whether I should just use IosDeviceManager
but didn't want to lock us into iOS platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but left a comment
Lots of UX improvements here:
--device-type
flag to force installation on a connected or simulator deviceDetects a simulator build:
Detects a device build: