Skip to content

Update Git params for Sentry upload #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+23 −85
Open

Update Git params for Sentry upload #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a79e242
Update Git params for Sentry upload
trevor-e Sep 16, 2025
7d1d705
bump
trevor-e Sep 16, 2025
d2921ff
bump
trevor-e Sep 16, 2025
aad2445
test
trevor-e Sep 16, 2025
647f181
add debug
trevor-e Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ios_emerge_upload_adhoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
sed -i '' "s/API_KEY/$ETDISTRIBUTION_API_KEY/g" HackerNews/Utils/Constants.swift
env:
ETDISTRIBUTION_API_KEY: ${{ secrets.ETDISTRIBUTION_API_KEY_IOS }}
- name: Build & upload iOS AdHoc binary to Emerge Tools
- name: Build & upload iOS AdHoc binary to Emerge Tools + Sentry
run: bundle exec fastlane ios build_upload_emerge
env:
ASC_KEY_ID: ${{ secrets.ASC_KEY_ID }}
Expand All @@ -57,3 +57,6 @@ jobs:
WIDGET_PROV_PROFILE_NAME: HackerNews AdHoc HomeWidget
ADHOC: true
APP_ID_SUFFIX: adhoc
PR_NUMBER: ${{ github.event.pull_request.number }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
BASE_REF: ${{ github.event.pull_request.base.ref }}
10 changes: 8 additions & 2 deletions .github/workflows/ios_emerge_upload_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
echo $CERTIFICATE_BASE64 | base64 --decode > signing-cert.p12

# This version uploads a build to Testflight
- name: Build & upload iOS size analysis binary to Emerge Tools
- name: Build & upload iOS size analysis binary to Emerge Tools + Sentry
run: bundle exec fastlane ios build_upload_testflight
env:
ASC_KEY_ID: ${{ secrets.ASC_KEY_ID }}
Expand All @@ -50,6 +50,9 @@ jobs:
SENTRY_SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_SENTRY_AUTH_TOKEN }}
CONFIGURATION: Release
EMERGE_BUILD_TYPE: release
PR_NUMBER: ${{ github.event.pull_request.number }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
BASE_REF: ${{ github.event.pull_request.base.ref }}

build_adhoc:
runs-on: macos-15
Expand Down Expand Up @@ -82,7 +85,7 @@ jobs:
run: |
echo $CERTIFICATE_BASE64 | base64 --decode > signing-cert.p12

- name: Build & upload iOS AdHoc binary to Emerge Tools
- name: Build & upload iOS AdHoc binary to Emerge Tools + Sentry
run: bundle exec fastlane ios build_upload_emerge
env:
ASC_KEY_ID: ${{ secrets.ASC_KEY_ID }}
Expand All @@ -99,3 +102,6 @@ jobs:
WIDGET_PROV_PROFILE_NAME: HackerNews AdHoc HomeWidget
ADHOC: true
APP_ID_SUFFIX: adhoc
PR_NUMBER: ${{ github.event.pull_request.number }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
BASE_REF: ${{ github.event.pull_request.base.ref }}
5 changes: 4 additions & 1 deletion .github/workflows/ios_emerge_upload_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: |
echo $CERTIFICATE_BASE64 | base64 --decode > signing-cert.p12

- name: Build & upload iOS size analysis binary to Emerge Tools
- name: Build & upload iOS size analysis binary to Emerge Tools + Sentry
run: bundle exec fastlane ios build_upload_emerge
env:
ASC_KEY_ID: ${{ secrets.ASC_KEY_ID }}
Expand All @@ -50,3 +50,6 @@ jobs:
SENTRY_SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_SENTRY_AUTH_TOKEN }}
CONFIGURATION: Release
EMERGE_BUILD_TYPE: pull-request
PR_NUMBER: ${{ github.event.pull_request.number }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
BASE_REF: ${{ github.event.pull_request.base.ref }}
76 changes: 0 additions & 76 deletions .github/workflows/ios_sentry_upload_pr.yml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ios/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
GIT
remote: https://github.com/getsentry/sentry-fastlane-plugin.git
revision: c76fc6cba6c0db6dff958d79fbc8880a570da75e
ref: c76fc6cba6c0db6dff958d79fbc8880a570da75e
revision: b0c36a1472a6bfde0a4766c612c1154706dbd014
ref: b0c36a1472a6bfde0a4766c612c1154706dbd014
specs:
fastlane-plugin-sentry (1.33.0)
os (~> 1.1, >= 1.1.4)
Expand Down
6 changes: 4 additions & 2 deletions ios/fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ platform :ios do
sentry_upload_build(
auth_token: ENV['SENTRY_SENTRY_AUTH_TOKEN'],
org_slug: 'sentry',
project_slug: 'launchpad-test-ios'
project_slug: 'launchpad-test-ios',
debug: true
)
end

Expand All @@ -189,7 +190,8 @@ platform :ios do
sentry_upload_build(
auth_token: ENV['SENTRY_SENTRY_AUTH_TOKEN'],
org_slug: 'sentry',
project_slug: 'launchpad-test-ios'
project_slug: 'launchpad-test-ios',
debug: true
)
end

Expand Down
2 changes: 1 addition & 1 deletion ios/fastlane/Pluginfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# Ensure this file is checked in to source control!

gem 'fastlane-plugin-emerge', '0.10.8'
gem 'fastlane-plugin-sentry', git: 'https://github.com/getsentry/sentry-fastlane-plugin.git', ref: 'c57d6a1'
gem 'fastlane-plugin-sentry', git: 'https://github.com/getsentry/sentry-fastlane-plugin.git', ref: 'b0c36a1'
Loading