Skip to content

Commit

Permalink
Increased MSRV to 1.65
Browse files Browse the repository at this point in the history
This MSRV was chosen to work with all dependencies.
  • Loading branch information
Emoun committed Apr 17, 2024
1 parent 1b504d3 commit 47d25fe
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 18 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ jobs:
strategy:
fail-fast: false
matrix:
rust-version: ['1.42.0', stable, beta, nightly]
rust-version: ['1.65.0', stable, beta, nightly]

steps:
- uses: actions/checkout@v2
- name: Run Test Groups
uses: ./.github/actions/run-test-groups
with:
rust-version: ${{ matrix.rust-version }}
minimal-versions: ${{ matrix.rust-version == '1.42.0' }}
minimal-versions: ${{ matrix.rust-version == '1.65.0' }}

deny-warnings:
name: Deny Warnings
Expand All @@ -46,7 +46,7 @@ jobs:
name: Rustfmt
runs-on: ubuntu-latest
env:
RUSTV: nightly-2021-12-26
RUSTV: nightly-2024-04-16
steps:
- uses: actions/checkout@v2
- name: Install
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- [BREAKING] Increased base MSRV to 1.65.

## [1.0.0] - 2023-03-10

### Changed
Expand Down
2 changes: 1 addition & 1 deletion cargo-readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ assert!(!42u32.is_max());

This crate's _Minimum Supported Rust Version_ (MSRV) depends on which features are enabled.

The _Base MSRV_ is 1.42. It applies when no features are enabled and is the lowest possible MSRV.
The _Base MSRV_ is 1.65. It applies when no features are enabled and is the lowest possible MSRV.
Enabling the following features increases the MSRV to the stated version:

_No features currently increase the MSRV beyond the base._
Expand Down
7 changes: 0 additions & 7 deletions tests/no_features/from/short_from_macro.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,7 @@ macro_rules! test_ident_from_macro_statement_variable{
//item_end
}
}
// We remove this test case for rust version <1.43 because the expansion
// of $name in 1.42 will produce an additional ';', which will cause 'duplicate'
// to throw an error (because there would be 2 ';' after each other in "$name ; [7]".
#[rustversion::since(1.43)]
test_ident_from_macro_statement_variable!(name);
// We add the expected expansion result so the test succeeds
#[rustversion::before(1.43)]
fn some_fn7(){7;}

macro_rules! test_ident_from_macro_token_tree_variable{
{ $name:tt } => {
Expand Down
7 changes: 0 additions & 7 deletions tests/no_features/from/verbose_from_macro.rs
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,7 @@ macro_rules! test_ident_from_macro_statement_variable{
//item_end
}
}
// We remove this test case for rust version <1.43 because the expansion
// of $name in 1.42 will produce an additional ';', which will cause 'duplicate'
// to throw an error (because there would be 2 ';' after each other in "$name ; [7]".
#[rustversion::since(1.43)]
test_ident_from_macro_statement_variable!(name);
// We add the expected expansion result so the test succeeds
#[rustversion::before(1.43)]
fn some_fn7(){7;}

macro_rules! test_ident_from_macro_token_tree_variable{
{ $name:tt } => {
Expand Down

0 comments on commit 47d25fe

Please sign in to comment.