Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed not displaying rewards balance when a withdrawal has been just processed #3403

Merged
merged 16 commits into from
Jan 31, 2024

Conversation

vsubhuman
Copy link
Contributor

No description provided.

@neuodev
Copy link
Contributor

neuodev commented Jan 26, 2024

[autoscirpt] Jira Ticket: Reward is received and rolled-back

@vsubhuman vsubhuman changed the title fixed not displaying rewards balance when pending withdrawal is present fixed not displaying rewards balance when a withdrawal has been just processed Jan 28, 2024
Base automatically changed from release/5.1.0 to production January 29, 2024 19:24
…nce-when-withdrawing

# Conflicts:
#	packages/yoroi-extension/app/containers/NavBarContainer.js
#	packages/yoroi-extension/app/containers/NavBarContainerRevamp.js
#	packages/yoroi-extension/app/containers/wallet/MyWalletsPage.js
#	packages/yoroi-extension/app/containers/wallet/dialogs/WalletRestoreDialogContainer.js
#	packages/yoroi-extension/app/containers/wallet/staking/CardanoStakingPage.js
#	packages/yoroi-extension/app/stores/toplevel/DelegationStore.js
@vsubhuman vsubhuman changed the base branch from production to develop January 30, 2024 09:35
nistadev
nistadev previously approved these changes Jan 30, 2024
Copy link
Contributor

@nistadev nistadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end! One step further for the good architecture state.

Nebyt
Nebyt previously approved these changes Jan 31, 2024
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit 416a07a into develop Jan 31, 2024
6 of 12 checks passed
@vsubhuman vsubhuman deleted the fix/YOEXT-969/balance-when-withdrawing branch January 31, 2024 20:49
@vsubhuman vsubhuman mentioned this pull request Feb 2, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants