Include mapColor in BlockMaterial and add more delegations to Forge/Fabric BlockMaterials#1956
Closed
DalekCraft2 wants to merge 1 commit intoEngineHub:masterfrom
Closed
Include mapColor in BlockMaterial and add more delegations to Forge/Fabric BlockMaterials#1956DalekCraft2 wants to merge 1 commit intoEngineHub:masterfrom
DalekCraft2 wants to merge 1 commit intoEngineHub:masterfrom
Conversation
…abric BlockMaterials
Author
|
Actually, I just discovered that the MCUtils repository shows some of the delegates to use for specific attributes, so I am going to update this again. |
Member
|
As we've deprecated the concept of bundled block data and added delegations separately, I'm going to close this PR. I'm also not sure if the map colour attribute is something we necessarily need/want at this point, as this PR doesn't seem to provide an actual usage of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I'll do stuff with translucency in the JSON files and MCUtil later. I'unno.