-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunk section editing #2621
Open
octylFractal
wants to merge
8
commits into
master
Choose a base branch
from
ot/featurefix/oooooo-you-like-editing-chunks-ur-a-chunk-section-editor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chunk section editing #2621
octylFractal
wants to merge
8
commits into
master
from
ot/featurefix/oooooo-you-like-editing-chunks-ur-a-chunk-section-editor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also drop all the old stuff that doesn't build any more and I'm _not_ going back and fixing it
octylFractal
force-pushed
the
ot/featurefix/oooooo-you-like-editing-chunks-ur-a-chunk-section-editor
branch
from
September 12, 2024 02:19
3f1652b
to
deb26cb
Compare
Needs to be updated to the new integrations at some point
@avaruus1 if you're interested in keeping the Sponge part up-to-date with everything, there are changes here that need to be made. As we don't want to maintain it, I just removed the broken code. This won't land for at least a couple months so there's plenty of time to adjust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Fabric-only.
TODO: