Switch ingestion to token chunking and add sample corpus #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngineerNV
commented
Oct 30, 2025
| CORPUS_DIR = os.environ.get("CORPUS_DIR", os.path.join("data", "corpus")) | ||
| HEADER_LEVELS = ["#", "##", "###"] # order matters | ||
|
|
||
| # Configure chunking in token units so the ingestion step aligns with embedding models. |
Owner
Author
There was a problem hiding this comment.
@copilot we need to review the ingestion of the tokens is done correctly and that we are setting up our build script for success. TODO: Review these changes - do they achieve the functionality of creating our chunks for embeddings? TODO: Test our build script along with the ingest script to ensure that our repo is functionally sound after these changes.
|
@EngineerNV I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you. |
…gestion Went from using markdown headers to now using tokens for chunking - with a 20% overlap.
EngineerNV
deleted the
codex/change-context-extraction-to-token-numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68fe777c3e188321b73869f4dec43017