Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two oversights #1

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Fix two oversights #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/org/quiltmc/loader/impl/launch/common/QuiltMixinBootstrap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,10 @@ public static int getMixinCompat(boolean isFabric, ModMetadata metadata) {
if (minLoaderVersion.compareTo(version.loaderVersion) >= 0) { // lower bound is >= current version
Log.debug(LogCategory.MIXIN, "Mod %s requires loader version %s, using mixin compatibility %s", metadata.id(), minLoaderVersion, version.mixinVersion);
return version.mixinVersion;
} else {
Log.debug(LogCategory.MIXIN, "Mod %s requires loader version %s, using 0.9.2 mixin compatability", metadata.id(), minLoaderVersion);
return FabricUtil.COMPATIBILITY_0_9_2;
}
}
Log.debug(LogCategory.MIXIN, "Mod %s requires loader version %s, using 0.9.2 mixin compatability", metadata.id(), minLoaderVersion);
return FabricUtil.COMPATIBILITY_0_9_2;
}

// Mod doesn't declare a dependency on a loader version; use oldest mixin compat version
Expand Down
1 change: 0 additions & 1 deletion src/main/java/org/quiltmc/loader/impl/launch/knot/MixinServiceKnot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ public ClassNode getClassNode(String name, boolean runTransformers) throws Class
public ClassNode getClassNode(String name, boolean runTransformers, int readerFlags) throws ClassNotFoundException, IOException {
ClassReader reader = new ClassReader(getClassBytes(name, runTransformers));
ClassNode node = new ClassNode();
reader.accept(node, 0);
reader.accept(node, readerFlags);
return node;
}
Expand Down