Skip to content

Enhance app store utilities and location handling #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShashankFC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance app store utilities and location handling #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app-store/locations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export const defaultLocations: DefaultEventLocationType[] = [
messageForOrganizer: "Provide a Meeting Link",
defaultValueVariable: "link",
iconUrl: "/link.svg",
category: "other",
category: "conferencing",
linkType: "static",
supportsCustomLabel: true,
},
Comment on lines 169 to 175
Copy link

@entelligence-ai-pr-reviews entelligence-ai-pr-reviews bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🟠 [LangGraph v3] Verify that changing 'category' from 'other' to 'conferencing' aligns with the intended logic, as it affects location categorization.

Expand Down
8 changes: 4 additions & 4 deletions packages/app-store/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function getApps(credentials: CredentialDataWithTeamName[], filterOnCredentials?
};
}

const credential: (typeof appCredentials)[number] | null = appCredentials[0] || null;
const credential: (typeof appCredentials)[number] | null = appCredentials[0];

reducedArray.push({
...appMeta,
Comment on lines 87 to 93
Copy link

@entelligence-ai-pr-reviews entelligence-ai-pr-reviews bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🟠 [LangGraph v3] The assignment appCredentials[0] || null is redundant since appCredentials[0] will naturally be undefined if it doesn't exist, which is already handled by the type | null. The change simplifies the code without altering its behavior.

Expand Down Expand Up @@ -122,10 +122,10 @@ export function getAppType(name: string): string {
const type = ALL_APPS_MAP[name as keyof typeof ALL_APPS_MAP].type;

if (type.endsWith("_calendar")) {
return "Calendar";
return "calendar";
}
if (type.endsWith("_payment")) {
return "Payment";
return "payment";
}
return "Unknown";
}
Comment on lines 122 to 131
Copy link

@entelligence-ai-pr-reviews entelligence-ai-pr-reviews bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🟠 [LangGraph v3] Change all return values in getAppType to lowercase for consistent casing.

Expand Down Expand Up @@ -160,7 +160,7 @@ export function doesAppSupportTeamInstall({
return !appCategories.some(
(category) =>
category === "calendar" ||
(defaultVideoAppCategories.includes(category as AppCategories) && !concurrentMeetings)
(defaultVideoAppCategories.includes(category as AppCategories) && concurrentMeetings)
);
}

Comment on lines 160 to 166
Copy link

@entelligence-ai-pr-reviews entelligence-ai-pr-reviews bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🟠 [LangGraph v3] The condition !concurrentMeetings was changed to concurrentMeetings, altering the logic. This may unintentionally change the function's behavior. Verify if this change is intended, as it affects when defaultVideoAppCategories are considered.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
return !appCategories.some(
(category) =>
category === "calendar" ||
(defaultVideoAppCategories.includes(category as AppCategories) && !concurrentMeetings)
(defaultVideoAppCategories.includes(category as AppCategories) && concurrentMeetings)
);
}
return !appCategories.some(
(category) =>
category === "calendar" ||
(defaultVideoAppCategories.includes(category as AppCategories) && concurrentMeetings)
);

Expand Down