Set Login Year to 2023 #1899
Merged
Set Login Year to 2023 #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailZhou
requested review from
ajaitasaini,
keeysnc,
britt-mo,
karla-vm and
benmartin-coforma
ailZhou
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
ailZhou
added
ready for review
britt-mo
previously approved these changes
Jul 27, 2023
gmrabian
previously approved these changes
Jul 28, 2023
gmrabian
reviewed
Jul 28, 2023
BearHanded
requested changes
Jul 31, 2023
|
Code Climate has analyzed commit f5dac75 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 50.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 72.7% (0.0% change). View more on Code Climate. |
karla-vm
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're finally doing it, we're making the login default reporting year 2023 in QMR.
Also, cypress test have been updated to select year 2021 so that it doesn't break everything.
Related ticket(s)
MDCT-2764
How to test
We will never have to make this mistake again.
Important updates
N/A
Author checklist
convert to a different template: test → val | val → prod