Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCT-2765 Pt. III: Add New Delivery Systems Validations #1909

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

karla-vm
Copy link
Contributor

@karla-vm karla-vm commented Aug 1, 2023

Description

Adding two (2) new validations for delivery systems and their nested selections to FFY2023 measures

Related ticket(s)

MDCT-2765


How to test

  • Log in as state user
  • Navigate to FY2023
  • Do not select an option for Which delivery systems are represented in the denominator?, like so:

Screenshot 2023-08-01 at 10 36 07 AM

Validate the measure and you should see this error message:

Screenshot 2023-08-01 at 10 36 30 AM

  • Next, select an option for that same question but don't select anything for the nested responses, like so:

Screenshot 2023-08-01 at 10 36 16 AM

Validate the measure and you should see this other error message:

Screenshot 2023-08-01 at 10 37 18 AM

Important updates

N/A


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@codeclimate
Copy link

codeclimate bot commented Aug 1, 2023

Code Climate has analyzed commit f5cb9a7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 72.7% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in browser, LGTM!

@karla-vm karla-vm merged commit eae40c0 into master Aug 1, 2023
166 checks passed
@karla-vm karla-vm deleted the validations-2765-3 branch August 1, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants