Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdct-3387 autocomplete CPA-AD for 2024 #2116

Closed
wants to merge 11 commits into from
Closed

cmdct-3387 autocomplete CPA-AD for 2024 #2116

wants to merge 11 commits into from

Conversation

britt-mo
Copy link
Contributor

Description

autocomplete CPA-AD for 2024

Related ticket(s)

CMDCT-3387


How to test

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@britt-mo britt-mo added the ready for review Ready for all the reviews! label Mar 15, 2024
Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good expect some text is missing:

Screenshot 2024-03-18 at 9 07 49 AM

There should be a performanceMeasureSubtext prop you can add this text to.

@britt-mo britt-mo requested a review from ailZhou March 18, 2024 16:06
@britt-mo britt-mo requested a review from ailZhou March 18, 2024 17:51
ailZhou
ailZhou previously approved these changes Mar 18, 2024
Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! changes are updated and CPA-AD is autocompleted by default

@benmartin-coforma benmartin-coforma dismissed stale reviews from ailZhou and themself via e542d4d March 18, 2024 22:35
@ajaitasaini ajaitasaini self-requested a review March 19, 2024 13:09
Copy link
Contributor

@ajaitasaini ajaitasaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codeclimate bot commented Mar 19, 2024

Code Climate has analyzed commit e031d4e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 73.7% (0.0% change).

View more on Code Climate.

@britt-mo britt-mo closed this Mar 19, 2024
@braxex braxex deleted the cmdct-3387 branch May 22, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants