Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdct 3352x - StatusOfData refactor #2150

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Cmdct 3352x - StatusOfData refactor #2150

merged 4 commits into from
Mar 29, 2024

Conversation

britt-mo
Copy link
Contributor

Description

StatusOfData refactor, removed folder from individual years and into the global common questions and types.

Related ticket(s)

CMDCT-3352


How to test

Go to any measure, see that 'Data Status' radio buttons appear beneath the first reporting question, and that text is the same across every reporting year

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@britt-mo britt-mo added the ready for review Ready for all the reviews! label Mar 26, 2024
ailZhou
ailZhou previously approved these changes Mar 27, 2024
Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tested on deploy, no issues with the component text or functionality wise

gmrabian
gmrabian previously approved these changes Mar 27, 2024
@britt-mo britt-mo dismissed stale reviews from gmrabian and ailZhou via a6cb52c March 27, 2024 18:55
Copy link

codeclimate bot commented Mar 28, 2024

Code Climate has analyzed commit a6cb52c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 73.4% (0.0% change).

View more on Code Climate.

@BearHanded BearHanded merged commit 81dfeed into master Mar 29, 2024
142 checks passed
@BearHanded BearHanded deleted the cmdct-3352x branch March 29, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants