[CMDCT-3843] react-query 5.0.5 (2 major versions) + React 18 #2365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
react-query
introduces vulns unless upgraded to 5.0.5.To do that we have to move to React 18.
To do both of those things we have to change some imports and comply with new method signatures.
These new changes were likely made just because some developer somewhere felt like it. Modern JS development is cursed.
The updated react-query devtools add a little icon to the screen, and I have used a recommended pattern to only show that in local development. We can adjust to more or less.
Related ticket(s)
CMDCT-3843
How to test
Try everything. Both of these packages touch everything.
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod