GV Refactor - ComplexNoNonZeroNumOrDenom

[ailZhou]

Description

This validation is only used in AIF-HH & IU-HH. It triggers when you manually override the rate in N/D/R and set it to 0 if numerator and denominator are not 0.

Example of AIF-HH:

When rate is zero in Performance Measure NDR:

When rate is zero in OMS NDR:

When rate is zero in Other Performance Measure - OMS NDR:

Related ticket(s)

CMDCT-3961

---

How to test

Deploy Link: https://dh6fso9hk982p.cloudfront.net/

1. Sign into QMR, stateuserWA@test.com
2. In reporting year 2024, select AIF-HH
3. In the Data Source section, check Other Data Source

To test Performance Measure

4. In Measure Specification section, select the first radio button
5. Scroll down to Performance Measure, and fill out the first row
   • change the values of the fields in the red square box to 0
     
6. Scroll down to the Optional Measure Stratification section and fill out a Total N/D/R, make the same changes as above.
7. Validate and you should see these 2 error messages.
   

Notes

---

Pre-review checklist

• I have added thorough tests, if necessary
• I have updated relevant documentation, if necessary
• I have performed a self-review of my code
• I have manually tested this PR in the deployed cloud environment

---

Pre-merge checklist

Review

• Design: This work has been reviewed and approved by design, if necessary
• Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

• These changes are significant enough to require an update to the SIA.
• These changes are significant enough to require a penetration test.

---

convert to a different template: test → val | val → prod

[codeclimate]

Code Climate has analyzed commit bf3f1ba and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 85.0% (0.7% change).

View more on Code Climate.

[angelaco11]

I am very excited about this refactor after having to work in this code before said refactor. This cleanup significantly improves the readability and flow of the code so great work.

tested on cloudfront and everything is working as expected!