Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GV Refactor - omsValidator #2436

Merged
merged 24 commits into from
Oct 7, 2024
Merged

GV Refactor - omsValidator #2436

merged 24 commits into from
Oct 7, 2024

Commits on Sep 16, 2024

  1. moved a validation to a better location

    @ailZhou
    ailZhou committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cdce2f9 View commit details
    Browse the repository at this point in the history

  2. fix unit test

    @ailZhou
    ailZhou committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4329e33 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'master' into cmdct-3965-oms-val

    @ailZhou
    ailZhou committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    14ca0ca View commit details
    Browse the repository at this point in the history

  2. slow cleaning

    @ailZhou
    ailZhou committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2adca0b View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. truncate several loops

    @ailZhou
    ailZhou committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    77609d2 View commit details
    Browse the repository at this point in the history

  2. test removing isfilled

    @ailZhou
    ailZhou committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7f535eb View commit details
    Browse the repository at this point in the history

  3. basic validation added back

    @ailZhou
    ailZhou committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e4b249d View commit details
    Browse the repository at this point in the history

  4. validation for addition & sub categories

    @ailZhou
    ailZhou committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ae4fed0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. better naming + complex validations

    @ailZhou
    ailZhou committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4e6fe49 View commit details
    Browse the repository at this point in the history

  2. adding callbacks back in

    @ailZhou
    ailZhou committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    359572c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into cmdct-3965-oms-val

    @ailZhou
    ailZhou committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4c491b3 View commit details
    Browse the repository at this point in the history

  4. added oms opm validation

    @ailZhou
    ailZhou committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9c5cb5b View commit details
    Browse the repository at this point in the history

  5. clean up

    @ailZhou
    ailZhou committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c7d1f29 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. expanded conditional

    @ailZhou
    ailZhou committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    64560b4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into cmdct-3965-oms-val

    @ailZhou
    ailZhou committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6f596fd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into cmdct-3965-oms-val

    @ailZhou
    ailZhou committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f4126cd View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. test updates

    @ailZhou
    ailZhou committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1405f05 View commit details
    Browse the repository at this point in the history

  2. Update validation.ts

    @ailZhou
    ailZhou committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b16d392 View commit details
    Browse the repository at this point in the history

  3. i just keep breaking everything

    @ailZhou
    ailZhou committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    450cc7e View commit details
    Browse the repository at this point in the history

  4. more clean up

    @ailZhou
    ailZhou committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e7ff5f4 View commit details
    Browse the repository at this point in the history

  5. opm test fix and dataDrivenTool fix

    @ailZhou
    ailZhou committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    31909cc View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'master' into cmdct-3965-oms-val

    @ailZhou
    ailZhou committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e56f1d0 View commit details
    Browse the repository at this point in the history

  2. fixes based on Brendan's feedback

    @ailZhou
    ailZhou committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2fb78c3 View commit details
    Browse the repository at this point in the history

  3. Make the OMS type definitions more complete

    @benmartin-coforma
    benmartin-coforma committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a36c5ab View commit details
    Browse the repository at this point in the history