Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GV Refactor - omsValidator #2436

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

GV Refactor - omsValidator #2436

wants to merge 21 commits into from

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Sep 16, 2024

Description

omsValidator is used to run all the validation related to the OMS section. So the omsValidator.tsx script has to handle checking the OMS N/D/R fields and run other OMS related functions that get passed in.

I ended up tossing all the previous code as it is really hard to follow and make the appropriate updates when changes arises.

Changes for omsValidator.tsx

  • Removed checkIsFilled prop - the whole purpose of this component is to check if the N/D/R has been filled. if we do not want to check that, we should just remove the validation. If we need specific checks, we should make more validations.
  • I broke down the script into a couple smaller functions or as small as they could be:

Related ticket(s)

CMDCT-3965


How to test

  1. Sign into QMR, any state user
  2. In Reporting Year 2024, select an adult core set
  3. Enter AAB-AD
  4. In the Measure Specification Section, select the first radio button

Notes

N/A


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@ailZhou ailZhou added the in progress In progress label Sep 16, 2024
Copy link

codeclimate bot commented Sep 24, 2024

Code Climate has analyzed commit 31909cc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 86.0% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou marked this pull request as ready for review September 24, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress In progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant