Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GV Refactor - validateDualPopInformation #2438

Merged
merged 2 commits into from
Sep 19, 2024
Merged

GV Refactor - validateDualPopInformation #2438

merged 2 commits into from
Sep 19, 2024

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Sep 17, 2024

Description

This is the same validation as ComplexValidateDualPopInformation but for measures that aren't AIF-HH & IU-HH.

Related ticket(s)

CMDCT-3967


How to test

Deploy Link: https://d1dfmq72e51wl1.cloudfront.net/

  1. Sign into QMR, stateuserWA@test.com
  2. In reporting year 2024, select AAB-AD
  3. In Measure Specification section, select the first radio button
  4. In Definition of Population Included in the Measure section, checkbox Denominator includes Medicare and Medicaid Dually-Eligible population
  5. Validate and you should see this error message
    Screenshot 2024-09-13 at 4 23 51 PM
  6. Do the steps 3 - 6 but for 2023 and you should see this error message
    Screenshot 2024-09-13 at 4 00 39 PM

Notes

N/A


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@ailZhou ailZhou marked this pull request as ready for review September 17, 2024 18:07
@ailZhou ailZhou added the ready for review Ready for all the reviews! label Sep 17, 2024
Copy link

codeclimate bot commented Sep 18, 2024

Code Climate has analyzed commit 6b29f0f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 82.6% (0.0% change).

View more on Code Climate.

@ajaitasaini ajaitasaini self-requested a review September 18, 2024 21:21
@ailZhou ailZhou merged commit 9db503e into master Sep 19, 2024
23 checks passed
@ailZhou ailZhou deleted the cmdct-3967-dualpop branch September 19, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants