GV Refactor - validateEqualCategoryDenominators #2439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This validation is for comparing the denominator values in an N/D/R set of certain measures with categories. The code was mostly the same for 2022- and 2023+ except:
categories.some((item) => item.label)
and the whole if statement is probably not necessary as we should only be calling this validation in measures that have categories, but I'm in the stage of if it ain't broke don't fix it.In the end, I copied over the 2024 file into the shared folder so no code was changed.
Related ticket(s)
CMDCT-3968
How to test
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod