Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GV Refactor - validateEqualCategoryDenominators #2439

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Sep 17, 2024

Description

This validation is for comparing the denominator values in an N/D/R set of certain measures with categories. The code was mostly the same for 2022- and 2023+ except:

Screenshot 2024-09-17 at 3 44 13 PM

categories.some((item) => item.label) and the whole if statement is probably not necessary as we should only be calling this validation in measures that have categories, but I'm in the stage of if it ain't broke don't fix it.

In the end, I copied over the 2024 file into the shared folder so no code was changed.

Related ticket(s)

CMDCT-3968


How to test

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Sep 17, 2024

Code Climate has analyzed commit 27b25b7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 82.6% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou marked this pull request as ready for review September 17, 2024 19:47
@ailZhou ailZhou added the ready for review Ready for all the reviews! label Sep 17, 2024
@ailZhou ailZhou merged commit bd7aebe into master Sep 18, 2024
27 checks passed
@ailZhou ailZhou deleted the cmdct-3968-equal-cat branch September 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants