Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GV Refactor - validateRateZero #2442

Merged
merged 2 commits into from
Sep 20, 2024
Merged

GV Refactor - validateRateZero #2442

merged 2 commits into from
Sep 20, 2024

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Sep 17, 2024

Description

A very simple change, this validation just needed to increase its type to allow both 2022- & 2023+ DefaultFormData type to be passed in.

This validation checks that if the numerator in the N/D/R of a measure is 0, then the rate should be 0.0.

Related ticket(s)

CMDCT-3973


How to test

Deploy Link: https://d31i8g21dyd3gl.cloudfront.net/

  1. Sign into QMR, any user
  2. Select any measure that collects Performance Measure data, i.s. AMM-AD
  3. In the Measure Specification Section, select the first radio button
    Screenshot 2024-09-18 at 9 25 07 AM
  4. In the Data Source Section, select anything but Administrative Data, this will allow you to manually change the rate in the N/D/R
    Screenshot 2024-09-18 at 9 25 16 AM
  5. In the Performance Measure Section, fill out an N/D/R. Numerator needs to be 0 and the Rate must be > 0
    Screenshot 2024-09-18 at 9 27 42 AM
  6. Scroll down and press the [Validate Measure] button. You should see this validation warning popup.
    Screenshot 2024-09-18 at 9 28 35 AM

Notes

N/A


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@ailZhou ailZhou marked this pull request as ready for review September 18, 2024 13:29
@ailZhou ailZhou added the ready for review Ready for all the reviews! label Sep 18, 2024
BearHanded
BearHanded previously approved these changes Sep 19, 2024
ajaitasaini
ajaitasaini previously approved these changes Sep 19, 2024
@ailZhou ailZhou dismissed stale reviews from ajaitasaini and BearHanded via 2fe1304 September 19, 2024 19:33
Copy link

codeclimate bot commented Sep 19, 2024

Code Climate has analyzed commit 2fe1304 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 82.6% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou merged commit 33db32e into master Sep 20, 2024
23 checks passed
@ailZhou ailZhou deleted the cdmct-3973-rate-zero branch September 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants