Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMDCT-3956] Kafka + Rates #2470

Merged
merged 14 commits into from
Oct 25, 2024
Merged

[CMDCT-3956] Kafka + Rates #2470

merged 14 commits into from
Oct 25, 2024

Conversation

BearHanded
Copy link
Contributor

@BearHanded BearHanded commented Oct 25, 2024

Description

Taking over the original PR because now there's a pile more.

  • Adds rates to the postKafka triggers and streams (thanks Aileen)
  • Adds Kafka topic creation and cleanup... :|
  • Updates existing kafka post library to the same version we use for .ts in other apps. This lets us use the same namespace pattern for cleanup.
  • Now handles missing NewImage when it is a delete operation

Related ticket(s)

CMDCT-3956


How to test

The logs on the postKafkaData lambda should be running without error.
It's very chatty with errors when it can't connect to bigmac or send a message.
Deployed branch for reference and manual interactions: https://d1i3grrahy03ww.cloudfront.net/

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Oct 25, 2024

Code Climate has analyzed commit 95bcb70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 86.5% (-1.5% change).

View more on Code Climate.

@BearHanded BearHanded marked this pull request as ready for review October 25, 2024 16:56
Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested by adding values to a measure and checking for a success in aws lambda monitor.

@BearHanded BearHanded merged commit 9c67301 into master Oct 25, 2024
23 of 25 checks passed
@BearHanded BearHanded deleted the cmdct-3956-kaf-rate branch October 25, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants