-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMDCT-3956] Kafka + Rates #2470
Conversation
Code Climate has analyzed commit 95bcb70 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 86.5% (-1.5% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! tested by adding values to a measure and checking for a success in aws lambda monitor.
Description
Taking over the original PR because now there's a pile more.
Related ticket(s)
CMDCT-3956
How to test
The logs on the postKafkaData lambda should be running without error.
It's very chatty with errors when it can't connect to bigmac or send a message.
Deployed branch for reference and manual interactions: https://d1i3grrahy03ww.cloudfront.net/
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod