Skip to content

feat: vscode client dynamically resolves artifact placement#185

Open
christso wants to merge 3 commits intomainfrom
feat/183-vscode-artifact-placement
Open

feat: vscode client dynamically resolves artifact placement#185
christso wants to merge 3 commits intomainfrom
feat/183-vscode-artifact-placement

Conversation

@christso
Copy link
Contributor

Summary

Closes #183

  • VSCode client no longer hardcodes .github/skills/ as its artifact location
  • New resolveClientMappings() function dynamically resolves vscode's mapping based on sibling clients:
    • Copilot present → vscode follows copilot (.github/skills/)
    • Copilot absent → vscode defaults to .agents/skills/ (universal behavior)
  • .code-workspace file generation is unchanged — always generated when vscode is configured

Client combination matrix

Clients Skills location Symlink?
vscode .agents/skills/ No
universal + vscode .agents/skills/ (deduped) No
copilot + vscode .github/skills/ (deduped) No
universal + copilot + vscode .agents/skills/ canonical, .github/skills/ → symlink Yes

Test plan

  • Unit tests for resolveClientMappings (8 tests covering all client combinations)
  • Integration tests for syncWorkspace vscode artifact placement (4 tests)
  • Updated existing dedup tests to use resolved mappings
  • Full test suite passes (795 pass, 0 fail)
  • Manual E2E: vscode-only places skills in .agents/
  • Manual E2E: copilot+vscode places skills in .github/

🤖 Generated with Claude Code

Wire resolveClientMappings into all sync entry points so vscode
artifacts land in .agents/ by default and follow copilot's .github/
path when copilot is also configured.

Integration points:
- copyValidatedPlugin: resolve mappings before deduplication
- syncWorkspace: resolve mappings for collectSyncedPaths
- syncUserWorkspace: resolve both copy and state-tracking paths
@cloudflare-workers-and-pages
Copy link

Deploying allagents with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba52290
Status: ✅  Deploy successful!
Preview URL: https://4d067058.allagents.pages.dev
Branch Preview URL: https://feat-183-vscode-artifact-pla.allagents.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: vscode client should only add code-workspace

1 participant