Fix 25 spec review issues across core and extensions#32
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 22, 2026
Merged
Fix 25 spec review issues across core and extensions#32gvonness-apolitical merged 1 commit intomainfrom
gvonness-apolitical merged 1 commit intomainfrom
Conversation
P0 (Correctness): - Replace undefined attachment block with link mark example - Add forms:form and forms:submit formal definitions and schema entries - Document locatorType field on citation mark - Add legal extension to extension index tables - Fix footnote number/symbol as conditional requirement - Add cross-extension footnote model guidance P1 (Consistency): - Document extension mark naming convention (Section 5.1) - Add CRDT metadata to hash boundary table - Change resetOn from chapter/section to heading levels - Clarify Person identity field divergence across extensions - Rename presentation figure numbering to numberingConfig - Add cross-reference mechanism selection guidance - Add change record and reply object field tables - Add field tables for all form field types - Document ACL enforcement model as advisory P2 (Quality): - Document glossary discovery and sort enum values - Add semantic:term field table and plain-string rationale - Note both CSL date formats as valid - Add presentation extension file paths section - Clarify forms:signature vs security digital signatures - Document "today" as only relative date keyword - Document phantom cross-reference limitations - Renumber section 1.5a to 1.6 - Clarify Dublin Core version vs Codex version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive remediation of 25 issues identified during spec review, organized by priority:
P0 — Correctness (6 issues)
attachmentblock example withlinkmark approachforms:formandforms:submitblock types (field tables + schema)locatorTypefield on citation mark (spec-schema alignment)number/symbolas conditional (not unconditionally required)P1 — Consistency (10 issues)
resetOnfromchapter/sectiontoheading1-heading6(schema + prose)userId,keyIdare additive, not replacements)numberingtonumberingConfigto resolve type mismatch with coreP2 — Quality (9 issues)
sortenum valuessemantic:termfield table + plain-string rationaleissuedfieldforms:signature(visual) vs security extension (cryptographic)"today"as only supported relative date keywordTest plan
npm test— all schemas compile, all examples validatenpm run check:sync— 65 block types synchronizednpm run check:refs— 71 cross-references validnpm run check:coverage— all 8 extensions and 15 schemas covered