Merged
Conversation
Both methods inlined the same reverse sweep loop that reverse_sweep_core already implements. Replace with calls to the shared function, which also picks up the zero-adjoint skip optimization in gradient_with_buf.
Prepare for submodule decomposition. Pure rename via git mv, zero content changes — preserves full blame history.
Split the 2,689-line monolith into logical submodules for navigability: mod.rs (struct + construction + accessors), forward.rs, reverse.rs, tangent.rs, jacobian.rs, sparse.rs, optimize.rs, taylor.rs, parallel.rs, serde_support.rs, thread_local.rs. Struct fields changed to pub(crate) for cross-module impl blocks. Seven internal methods upgraded to pub(super) for cross-module calls. Zero public API or behavioral changes.
BytecodeTape decomposition (10 submodules), reverse sweep deduplication, CUDA macro extraction, nalgebra 0.34, and accumulated doc/test improvements since v0.3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gradient_with_buf()andsparse_jacobian_par()now call sharedreverse_sweep_core()instead of inlining the loopTest plan
cargo test --features "bytecode,taylor,stde,diffop,serde,faer,nalgebra,ndarray"passescargo test -p echidna-optimpassescargo clippyclean