-
Notifications
You must be signed in to change notification settings - Fork 21
Try using select instead of add/mul #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ah dangit accidentally added copilot as a reviewer |
The large grid full GB-25 run had the message
while in https://github.com/EnzymeAD/Enzyme-JAX/actions/runs/17466827030/job/49604725985?pr=1363#step:19:749 we had
which is an increase in the extra total memory, but I'm not sure this is a 1:1 comparison, some things changed in the meantime. |
Hm can we set up a one to one comparison just to confirm? |
Also just double checking (I did locally earlier too), we remain good on all-X? |
I think so, I didn't see them in this dump: https://github.com/EnzymeAD/Enzyme-JAX/actions/runs/17466827030/artifacts/3928490250 |
This what we currently get on main, when trying to use a larger grid: https://github.com/EnzymeAD/Enzyme-JAX/actions/runs/17470175868/job/49619910051?pr=1365#step:19:749
So this PR seems to cause more memory usage overall? |
No description provided.