feat: support cluster dims in kernel call op #1487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/kernel_call_cluster_dims
branch
from
2e8a601 to
5084fb6
Compare
|
GB-25 error is expected, we need to regenerate the new bindings before using it on julia end |
wsmoses
reviewed
Oct 18, 2025
| TensorI64:$blocky, | ||
| TensorI64:$blockz, | ||
| TensorI64:$shmem, | ||
| Optional<TensorI64>:$clusterx, |
There was a problem hiding this comment.
why have it be optional, instead just default set to 1?
There was a problem hiding this comment.
We will have to update all of the current mlir files to include cluster(x/y/z)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
EnzymeJAX Benchmarks
| Benchmark suite | Current: 5084fb6 | Previous: a7c38bc | Ratio |
|---|---|---|---|
add_two / JaX / cpu / Primal |
0.0000037910791999820505 s |
0.0000038976957999693696 s |
0.97 |
add_two / JaXPipe / cpu / Primal |
0.000003752150000036636 s |
0.00000598926249986107 s |
0.63 |
add_two / JaX / cpu / Forward |
0.000005994758399901912 s |
0.000008238229199923807 s |
0.73 |
add_two / JaXPipe / cpu / Forward |
0.000005851249999977881 s |
0.000008194375000130095 s |
0.71 |
add_two / JaX / cpu / BothRev |
0.000007452575000024808 s |
0.000011886500000036904 s |
0.63 |
add_two / JaXPipe / cpu / PreRev |
0.000007561033300044073 s |
0.000009867437499997322 s |
0.77 |
add_two / JaXPipe / cpu / PostRev |
0.000007304525000108697 s |
0.000010835137499998382 s |
0.67 |
add_two / JaXPipe / cpu / BothRev |
0.000007404462500016962 s |
0.000013692654199985554 s |
0.54 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
again mostly for triton where we need this if
num-ctas > 1