Support persistent MPI #2535
Draft
Support persistent MPI #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Nov 6, 2025
| // Adjoint of MPI_Send is to place a MPI_send at the corresponding | ||
| // location in the reverse. | ||
| if (func == "MPI_Send" || func == "PMPI_Send") { | ||
| if (Mode == DerivativeMode::ReverseModeGradient || |
Member
There was a problem hiding this comment.
did we miss this from earlier??
if so we should add a test
Member
Author
There was a problem hiding this comment.
Sorry this was a brain fart on my side this ought to be MPI_Start not MPI_Send
wsmoses
reviewed
Nov 6, 2025
| auto callval = call.getCalledOperand(); | ||
| Value *args[] = { | ||
| lookup(gutils->getNewFromOriginal(call.getOperand(0)), Builder2)}; | ||
| Builder2.CreateCall(call.getFunctionType(), callval, args); |
Member
There was a problem hiding this comment.
doesn't cover fwd mode, so we shouldn't return in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
MPI_Send_init,MPI_Recv_initandMPI_Start