fix: try to make searchsortedfirst raising work again #1700
+334
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if it hits raising that means we're likely not hitting a relevant overload? |
avik-pal
commented
Sep 24, 2025
| )::TracedRNumber{keytype(a)} | ||
| x = TracedUtils.promote_to(TracedRNumber{Reactant.unwrapped_eltype(a)}, x) | ||
|
|
||
| @eval function Base.searchsortedfirst(a::$(aType), x::$(xType), o::Base.DirectOrdering) |
There was a problem hiding this comment.
It is hitting this (confirmed with the good old way of changing the function and checking the traced mlir). not sure if we want to call into some other function
There was a problem hiding this comment.
hm who is still calling the kernel then, that's weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can confirm that we are now hitting the custom dispatch for
searchsortedfirstbut raising still seems to fail