Remove stopit imports, references, and dependency#1391
Open
reevesc7 wants to merge 1 commit intoEpistasisLab:mainfrom
Open
Remove stopit imports, references, and dependency#1391reevesc7 wants to merge 1 commit intoEpistasisLab:mainfrom
stopit imports, references, and dependency#1391reevesc7 wants to merge 1 commit intoEpistasisLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
stopitas a dependency and all (non-archived) references to it.Removed code references include
tpot.utils.eval_utils.optimize_objective()andtpot.utils.eval_utils.parallel_optimize_objective().Where should the reviewer start?
tpot/utils/eval_utils.pypyproject.tomlREADME.mdHow should this PR be tested?
A fresh install and standard tests may be appropriate to validate that the dependencies resolve properly.
The removed references to
stopitwere not referenced anywhere else within TPOT, but their removal would cause incompatibilities with any external scripts callingtpot.utils.eval_utils.optimize_objective()ortpot.utils.eval_utils.parallel_optimize_objective()....Maybe a deprecation warning would be appropriate, but as I describe below, there was already a deprecation warning being printed related to these functions.
Any background context you want to provide?
stopitimportspkg_resources, which was deprecated and is now removed.For some time,
pkg_resourcesprinted a deprecation warning stating that the module would be removed in the near future.That future has come, and now fresh installations may no longer function due to
stopitstill attempting to importpkg_resources.In fact, I discovered that
pkg_resourceshas been removed when freshly installing TPOT to make a different pull request.Unfortunately,
stopitis no longer maintained.The last update to its repository occurred 3 years ago.
The fix for the
pkg_resourcesissue is simple, and thestopitrepository has the fix waiting in a pull request.However, the request has remained open for a year and a half.
Given that
stopitis unlikely to regain functionality in the near future and that the TPOT internals do not utilize the module, I figured it would be best to remove the dependency.Alternatively, spraakbanken/stopit2 is a fork of
stopitwhich implements thepkg_resourcesfix.If maintainers desire to keep
stopit-like functionality within TPOT,stopit2may be a fitting choice.What are the relevant issues?
None that I found during a quick search.
Questions:
stopit