Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

Execute format check on CI pipeline #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Execute format check on CI pipeline #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ node_js:
- "10"
deploy:
provider: script
script: yarn install && yarn run deploy
script: yarn install && yarn format:check && yarn run deploy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want format:write, don't we?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I'm not 100% sure what you're trying to do here. I'm busy right now, but maybe I can have a go at lunchtime. what we want, I think, is a pre-commit hook.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://prettier.io/docs/en/precommit.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be the contributor's responsibility to commit changes according to the repositories style guide. How they do it should be up to the individual.

Having that said, the purpose of this PR is just to enforce these rules through an additional check. Therefore I've added the yarn format:check cmd which will return a non-zero exit code if the commit is not aligned with the style guide.

skip_cleanup: true
on:
branch: master
branch: master
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
"build": "gatsby build --prefix-paths",
"develop": "gatsby develop",
"deploy": "gatsby build --prefix-paths && gh-pages -d public -r https://$GH_TOKEN@github.com/EqualExperts/equalexperts-de.git",
"format": "prettier --write \"**/*.{js,jsx,json,md}\"",
"format:check": "prettier --check \"**/*.{js,jsx,json,md}\"",
"format:write": "prettier --write \"**/*.{js,jsx,json,md}\"",
"start": "npm run develop",
"serve": "gatsby serve",
"clean": "gatsby clean",
Expand Down