Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blackdagger-installer.sh #33

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

akindemirsec
Copy link
Contributor

This pull request fixes an installation issue when the /usr/local/bin/ directory does not exist. The change fixes the installation issue by adding a check to ensure the directory exists

If directory doesn't exists script fails with an error
Screenshot from 2024-03-23 20-05-38

There i am creating /usr/local/bin/ directory
Screenshot from 2024-03-23 20-06-32

After creating directory problem solves, so I've added a check in installation script for the solution

Screenshot from 2024-03-23 20-06-58

@ataseren
Copy link
Contributor

LGTM

@ErdemOzgen
Copy link
Owner

@GrimezSec Can you please change /usr/local/bin to /usr/bin It will be more elegant.

@ErdemOzgen
Copy link
Owner

@GrimezSec Can you also do same things for gotty

Like this line: sudo mv "${TMPDIR}/gotty" /usr/local/bin/

Copy link
Owner

@ErdemOzgen ErdemOzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErdemOzgen ErdemOzgen merged commit 4460743 into ErdemOzgen:main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants