Dynamic parallel cpu DAG scheduler 🚀#22
Merged
EricLBuehler merged 1 commit intomasterfrom Apr 26, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a dynamic CPU DAG scheduler inspired by CUDA streams for improved parallel execution and concurrency. Key changes include:
- Replacing Rc/RefCell with thread-safe Arc, Mutex, and AtomicUsize in tensor ID management.
- Updating the buffer pool to use Arc<Mutex<…>> for thread safety.
- Revamping the DAG evaluation logic in the CPU storage module with concurrent scheduling using rayon and mpsc for synchronization.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| constensor-core/src/graph.rs | Replaces Rc/Cell with Arc/AtomicUsize for advanced thread-safe tensor ID handling. |
| constensor-core/src/cpu_storage/pool.rs | Updates shared pool type to Arc<Mutex<BufferPool>> for safe concurrent buffer management. |
| constensor-core/src/cpu_storage/mod.rs | Implements dynamic DAG scheduling with concurrency primitives and parallel task spawning. |
Comments suppressed due to low confidence (2)
constensor-core/src/cpu_storage/mod.rs:408
- [nitpick] For consistency with the rest of the evaluation branches, consider using unreachable!("NoOp should not be evaluated") instead of panic!().
Op::NoOp => panic!("NoOp should not be evaluated"),
constensor-core/src/cpu_storage/mod.rs:420
- [nitpick] Variable names like 'pool2', 'ng2', 'res2', etc. are ambiguous; consider using more descriptive names to improve code clarity.
let pool2 = pool.clone();
Owner
Author
|
Before: After This is ~30% faster! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the idea of CUDA streams.