Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint to include more data with AST node metrics #755

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Endpoint to include more data with AST node metrics #755

merged 4 commits into from
Jul 1, 2024

Conversation

intjftw
Copy link
Collaborator

@intjftw intjftw commented Jun 29, 2024

As it was requested, I created a new endpoint that includes more AST node data along with the list of available metrics. It is in WIP status as I still need to add more data and test the endpoint.

@intjftw intjftw added Kind: Enhancement 🌟 Status: WIP 👷 Issue or PR under development - feel free to review, though! Plugin: C++ Issues related to the parsing and presentation of C++ projects. Plugin: Metrics Issues related to the code metrics plugin. labels Jun 29, 2024
@intjftw intjftw requested a review from mcserep June 30, 2024 20:51
@intjftw intjftw removed the Status: WIP 👷 Issue or PR under development - feel free to review, though! label Jun 30, 2024
mcserep
mcserep requested changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine apart from minor issues.

plugins/cpp_metrics/service/cxxmetrics.thrift Outdated Show resolved Hide resolved
plugins/cpp_metrics/service/cxxmetrics.thrift Show resolved Hide resolved
plugins/cpp_metrics/service/cxxmetrics.thrift Outdated Show resolved Hide resolved
plugins/cpp_metrics/service/cxxmetrics.thrift Outdated Show resolved Hide resolved
@intjftw intjftw requested a review from mcserep July 1, 2024 08:20
@mcserep mcserep added this to the Upcoming Release milestone Jul 1, 2024
mcserep
mcserep approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@mcserep mcserep merged commit c2acf2c into Ericsson:master Jul 1, 2024
14 checks passed
@mcserep mcserep deleted the modify-ast-endpoint branch July 1, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcserep mcserep mcserep approved these changes

Assignees
No one assigned
Labels
Kind: Enhancement 🌟 Plugin: C++ Issues related to the parsing and presentation of C++ projects. Plugin: Metrics Issues related to the code metrics plugin.
Projects
None yet
Milestone
Upcoming Release
Development

Successfully merging this pull request may close these issues.
2 participants
@intjftw @mcserep